Custom Signs: Misleading instructions for task 3

1
open
andrerfcsantos
andrerfcsantos
Posted 5 months ago

Custom Signs: Misleading instructions for task 3 #1931

Task 3 of the concept exercise custom-signs states:

If the age is 50 or older, the sign will include the word mature, otherwise the sign will include the word young.

This made me believe that the tests would accept any message for the sign, as long as it included the word mature if the age is 50 or older, or the word young otherwise. However, that seems to not be the case, and the tests expect only very specific strings:

https://github.com/exercism/javascript/blob/2be1e8e8585f14213b44374d98162b18aa1eded3/exercises/concept/custom-signs/custom-signs.spec.js#L21-L31

I think either the description should be changed to state the phrase accepted is the one on the example provided or alternatively the tests should be changed to accept any phrase, in which case they would only for the presence of young or mature in those phrases.

tejasbubane
tejasbubane
Created 5 months ago

@andrerfcsantos Thanks for spotting this! :+1: Should be fixed in #1934